Mobile UI for desktop

Progress update:
After a bunch of fixes 2-pane ui for mobile platforms finally merged!

So now it is time to make mobile ui the default one for desktop platforms.

4 Likes

great work guys. Looking forward to using the new desktop ui.

@volodymyr.kozieiev could you confirm that if we remove realm it will be much easier to remove the ubuntu-server? I’m making a plan to remove realm WIP https://notes.status.im/removing-realm

3 Likes

@yenda, yes, it is correct!

hey @volodymyr.kozieiev what are our next steps? can we use mobile screens and remove desktop ones?

@andrey, correct, these are next steps:

  • run 2-pane mobile UI on desktop,
  • make mobile UI default for desktop,
  • remove old desktop UI

Right now working on the first one .

1 Like

Current issue:
We already have flag in .env file that enables mobile ui for desktop. But since it was last checked mobile ui switched to react-navigation v3. And newer navigation depends on react-native-gesture-handler library that provides native (ios and android) ways to deal with gestures. It looks like we need to support this library on desktop to reuse latest mobile UI :-/

what project is this?

Progress update:

  • react-native-gesture-handler mock created

After this few problems revealed that fixed in `react-native-desktop:

  • Added implementation of pointerEvents property of View
  • Fixed internal events propagation.

Now 2-pane mobile UI works fine with desktop. PR with test builds created. It needs full testing to find all small issues before merging to develop.
So far known issues are:

  • Text input in chat gains focus only when clicked in the leftmost part of area.
  • Window that opens after click on “share my profile” has broken layout

Working on them.

6 Likes

Volodymyr you’re a one man army, incredible work man!

1 Like

Progress update:

  • Fixed issue with text input focus and not always working “send” button in chat.
  • Started work on implementing shadows in react-native-desktop View component. It is crucial for design.

Bunch of issues were collected for mobile UI desktop builds. Most of them are desirable UI improvements but some should be implemented on react-native-desktop side, like shadows mentioned above.

Note: I’m on a long vacation till 2nd September, so will continue when return.

2 Likes

Quick update:
I returned from vacation and continue 2-pane UI. A lot of changes were made in develop during these 3 weeks, so fixes needed to make 2-pane PR work again. So far desktop compiling was fixed in develop branch and added missed functions in react-native-status. Now working on problem with logging in on desktop.

5 Likes

Any recent updates about this?

1 Like

@jakubgs,
During this time was fixed issue with login, keychain build (thanks @pedro), desktop icons.
Currently desktop builds and runs successfully on my local computer. For jenkins tests should be fixed. This is in progress now.

You’re welcome!

This morning I tried the current branch and got an error regarding AppRegistry. Do you have commits which aren’t pushed to GitHub?

No, all my changes in branch now.

When I run the build from CI I see this at startup:

image

Also tried building release on Linux but I don’t see a window.

@pedro, I’m on mac now and running dev build, not release. Ci build is not yet available for mac. @jakubgs looks into that problem.

Btw, because for ios and android images now mostly loaded from assets, my latest fix for loading desktop icons breaks android build. So I’m going to implement storing and loading images inside resources for desktop - https://github.com/status-im/react-native-desktop/issues/506

@pedro, created release package for mac and also don’t see window :-/ Checking it.

Problem with not visible window is about outdated ubuntu-server. It should be updated in a bundle. Old ubuntu-server still tries to load realm data from non-existent node_modules dir.
But problem with “AppRegistry is not a registered…” is about something else.